fix: api references and docs #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 861cb31 in 2 minutes and 46 seconds
More details
- Looked at
1568lines of code in101files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. docs/scripts/render_mint_json_template.js:19
- Draft comment:
Consider adding a check to ensure the directory exists and is not empty before attempting to read '.mdx' files. This will prevent potential errors if a directory is empty or missing. - Reason this comment was not posted:
Confidence changes required:50%
The script is designed to read directories and files to generate a JSON structure. However, it assumes that all directories in 'api-reference' contain '.mdx' files, which might not always be the case. Adding a check for directory existence and handling empty directories would make the script more robust.
Workflow ID: wflow_OIuqwV6koBumuIR9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
utkarsh-dixit
requested review from
himanshu-dixit and
plxity
as code owners
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 556c51d in 1 minute and 3 seconds
More details
- Looked at
38lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_EvsVQ7yETPUvEAbw
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
js/examples/e2e/demo.mjs
Outdated
|
|
||
| const result = await toolset.client.actions.findActionEnumsByUseCase({ | ||
| apps: ["gmail", "googledrive"], | ||
| useCase: "get repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo informationget repo information", |
There was a problem hiding this comment.
The useCase string is excessively long and repetitive. Consider replacing it with a meaningful and concise description.
js/examples/e2e/demo.mjs
Outdated
| @@ -1,24 +1,17 @@ | |||
| import { Composio, LangchainToolSet } from "composio-core"; | |||
| import { z } from "zod"; | |||
|
|
|||
| const toolset = new LangchainToolSet(); | |||
| const toolset = new LangchainToolSet({ | |||
| apiKey: "4q7w9q6evy2fiisjgwoc8i" | |||
There was a problem hiding this comment.
Avoid hardcoding API keys in the source code. Consider using environment variables or a secure configuration management system.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 37f3bdf in 39 seconds
More details
- Looked at
129lines of code in10files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. docs/api-reference/triggers/update-new-webhook.mdx:2
- Draft comment:
Consider using hyphens instead of underscores in the endpoint path to maintain consistency with other endpoints. - Reason this comment was not posted:
Confidence changes required:50%
The new endpoint 'update-new-webhook' is added to the triggers group in the mint.json file. However, the naming convention for the endpoint is inconsistent with the other endpoints in the same group, which use hyphens instead of underscores.
Workflow ID: wflow_jzVqwLogC7VdLQ6M
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
Skipped PR review on 7ee3adf because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
There was a problem hiding this comment.
Skipped PR review on cc2c652 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b1754d8 in 41 seconds
More details
- Looked at
38lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/examples/e2e/demo.mjs:6
- Draft comment:
Consider adding error handling for asynchronous operations to ensure robustness. - Reason this comment was not posted:
Confidence changes required:50%
The code is missing error handling for asynchronous operations, which is a best practice to ensure robustness.
Workflow ID: wflow_tDp5q9C5325i1CML
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This pull request updates API references, restructures endpoints, and enhances documentation generation using EJS templating.
docs/api-referencefor actions, apps, client, connections, and triggers.composio_openapi.jsonto reflect new endpoint structures.generate:devscript inpackage.jsonfor development environment.render_mint_json_template.jsto dynamically generatemint.jsonfrommint.json.ejsusing EJS templating.mint.jsonandmint.json.ejsto reflect new API reference structure and navigation.demo.mjsfor testing purposes.This description was created by
for b1754d8. It will automatically update as commits are pushed.